bjg wrote:Just sent a bug report game_919. Why can't it attack the planet?

Which planet? (I'm able to attack Alpheratz I without trouble.)

Edit: At Sargas III, you don't have an "Invade" option, but that's because you have no ground troops in orbit. (I should probably add a tooltip explaining this.)

Alpheratz III.
I thought uploaded errors are self explanatory. Don't they include actual error messages?

bjg wrote:Alpheratz III.
I thought uploaded errors are self explanatory. Don't they include actual error messages?

Ah, yes, they do. I misunderstood -- I though you were reporting a UI bug, like the missing attack icon in some of the marauder encounters. I see your stack trace now...

sven wrote:Ah, yes, they do. I misunderstood -- I though you were reporting a UI bug, like the missing attack icon in some of the marauder encounters. I see your stack trace now...

It might make sense to name those something like error_* instead of game_*.

bjg wrote:Alpheratz III.
I thought uploaded errors are self explanatory. Don't they include actual error messages?

Ok, I can see from the logs that an error was generated when you clicked "attack", but I can't get the same error to come up. I think the issue may be somehow related to the fleet ship selection logic -- did you have some ships in the fleet selected/unselected when the error occurred? Do you recall doing anything unusual with the ship selection options just prior to the attack?

I can't reproduce it from the save neither.
Yes, I was clicking individual ships (all but the DS) to unselect them (right click to reverse would help here a lot). It was a lot of ships, I was missing, clicking "?" (by mistake).

Version 15008 Dev
In windowed mode, clicking on the window border X, closes the application without confirmation again. The safety dialog seems to be gone.

Some abuseing the new renaming feature:
- The Heavy Metal Umlauts ö,ä,ü and letter ß are shown as blocks (font doesn't know what to do with them. probably all language specific characters)
- some special characters are not working, it seems all combinations with ALT-GR (CTRL+ALT on EN keyboards) are ignored.
- I broke the game
a name with several mad characters produced "Invalid use of '%' in replacement string". But using % in a name does seem to work.
(error report game_922. maybe you can see what madnes I entered there, I was facerolling the keyboard...)
- Outposts can't be renamed (probably intended)
- renaming a colony while a related advisor popup is open works fine, the name is updated at once.

SirDamnALot wrote:Version 15008 Dev
In windowed mode, clicking on the window border X, closes the application without confirmation again. The safety dialog seems to be gone.

Opps.

edited by sven: Should be working as intended again as of r15009.

SirDamnALot wrote:Some abuseing the new renaming feature:
- The Heavy Metal Umlauts ö,ä,ü and letter ß are shown as blocks (font doesn't know what to do with them. probably all language specific characters)
- some special characters are not working, it seems all combinations with ALT-GR (CTRL+ALT on EN keyboards) are ignored.

Yes. This is a known issue, and one I'd like to fix before release. The vera sans font we're using should have these assets, so it would just be a question of loading them up -- but the big "cartoon title" font probably doesn't cover extended ASCII characters, which is a bit of an issue... At the very least, I could, in theory, be auto-filtering characters input in the extended ASCII charset using the classic ü -> ue type substitutions.

Cyrillic characters are just going to be a disaster though. We just don't have the assets to handle them well.

SirDamnALot wrote:- I broke the game
a name with several mad characters produced "Invalid use of '%' in replacement string". But using % in a name does seem to work.
(error report game_922. maybe you can see what madnes I entered there, I was facerolling the keyboard...)

Good work! I got your game upload. Tracking down the bug. That's one I didn't anticipate, but I believe I understand, more or less, what's happening

edited by sven: Ah yes, good old <>δas+όδ$%&/ appears to be causing a number of fascinating formatting issues, including at least 1 hard crash

edited by sven: As of r15011, adding '%' to ship and planet names should no longer be possible, which I believe should fix the most serious of these bugs. Many special characters can still cause issues, of course. I should probably just compose a quick whitelist of allowed characters, rather than trying to handle all of the (potentially UTF16 formated) character codes windows sends my way.

SirDamnALot wrote:- The Heavy Metal Umlauts ö,ä,ü and letter ß are shown as blocks (font doesn't know what to do with them. probably all language specific characters)

It looks like our cartoon font actually does include most of the Heavy Metal glyphs. I just uploaded a (somewhat experimental) version of the binaries that extends our text rendering to cover the full extended ASCII character set, so we should now be showing ö,ä,ü and ß, as of r15012 ('dev'). Let me know if you can trigger any bugs/glitches with Heavy Metal planet or ship names

SirDamnALot wrote:- some special characters are not working, it seems all combinations with ALT-GR (CTRL+ALT on EN keyboards) are ignored.

Yes. This is because I'm using CTRL+ALT for other hotkeys, so the normal special character text input shortcuts won't work. However, if you have a German keyboard, I believe you should still be able to enter ö,ä,ü, etc.

Version r15015 Dev

Playing again with the planet names:
- The german umlauts ö,ä,ü are working fine. Planet Motörhead is happy
- Our funky letter ß gets translates as SS...which you probably shouldn't do, some people may get weird about that.
- Letter § gets the blocky treatment. A whitelist may be the way to go. UTF knows so many silly letters and symbols, it's madness
- A lot of french letters (vowels with stuff above them ) work fine.
- sometimes the new planetname is not commited on enter, the old one jumps back in to the name field.
e.g. replace the name with "/*-+", while accepted by the text field, is silently rejected by the game.

Quirks, not bugs (maybe):
- Just noticed that upper and lowercase are the same letter, but bigger and smaller
- the text courser is not always placed before the letter, but in the middle of the letter. Becomes apparant if you have long names and place the courser on the far right letters. (only windowed mode, probably letter width calculation combined with scaling is off)

Quit dialog box has shown up back for work

SirDamnALot wrote:- Our funky letter ß gets translates as SS...which you probably shouldn't do, some people may get weird about that.
- Just noticed that upper and lowercase are the same letter, but bigger and smaller

These two are probably related. I don't know much about German language/writing, but, the cartoon title font is an "all caps" style. Apparently, "all caps" is not a common concept in German typography -- though in English typesetting, it is a thing. And that creates a glyph definition problem. According to wikipedia, "SS" is one theoretically correct rendering of "capital ß", but, if it looks bizarre to a native German reader, then it must be an archaic form or something. Do you think it's better to simply not allow "ß" as input, or should I replace "ß" with "s" or "ss"?

(I could also probably ask Nate if he could make us a quick lower-case style "ß". He's pretty good about responding to emails, and it might not be a big deal.)

sven wrote:

SirDamnALot wrote:- Our funky letter ß gets translates as SS...which you probably shouldn't do, some people may get weird about that.
- Just noticed that upper and lowercase are the same letter, but bigger and smaller

These two are probably related. I don't know much about German language/writing, but, the cartoon title font is an "all caps" style. Apparently, "all caps" is not a common concept in German typography -- though in English typesetting, it is a thing. And that creates a glyph definition problem. According to wikipedia, "SS" is one theoretically correct rendering of "capital ß", but, if it looks bizarre to a native German reader, then it must be an archaic form or something. Do you think it's better to simply not allow "ß" as input, or should I replace "ß" with "s" or "ss"?

The "all caps" thing is indeed unusual for Germany, but it looks cute. I would keep it

The ß is a funky special case, really . While in some cases you can replace a ß with ss.
Like in "Straße" VS "Strasse" (street/road), but a "Maßkrug" can't be a "Masskrug" (beer mug, think Oktoberfest).
An uppercase version was always a point of discussion (since, like ever). While there is now an ISO ruling on that matter,
German Rechtschreibung (orthography) is not bound by that. You may use ss or ß as needed.
The thing with SS are the unfortunate implications, associated with the uppercase spelling.
So I would block the crazy letter, and let people type themself the "ss" as a replacement when they think they need one.
Old geezers may even still know the outdated SZ replacement

SirDamnALot wrote:- the text courser is not always placed before the letter, but in the middle of the letter. Becomes apparant if you have long names and place the courser on the far right letters. (only windowed mode, probably letter width calculation combined with scaling is off)

I'm having a hard time replicating this behavior. The cursor positions are sometimes a little off for me, but, I can't figure out how to get extreme errors, like a cursor appearing in the middle of a letter. Can you give me an example of a name that's causing cursor position issues for you?

edited by sven: Found one. The double II in Rastaban II is off... I wouldn't mind one or two other good examples though, if you discover them.

sven wrote:edited by sven: Found one. The double II in Rastaban II is off... I wouldn't mind one or two other good examples though, if you discover them.

Here is an easy one (zoomed in paint)

The courser is inside the M and also alternates between 2 and 3 pixel width between letters.
(Thus the thought about scaling being a part of the problem)

SirDamnALot wrote:(Thus the thought about scaling being a part of the problem)

"RRRRRRRRRRRRRRRRRRRRRR" is capable of producing really extreme errors. Scaling is clearly part of the issue -- my hunch is that I may be failing to take a scale factor into account when adjusting for kerning or something.

edited by sven: These cursor alignment issues should be fixed as of r15038